From 3344a7b4a7fe7e0aeec2280d0dbb21d1bb6d7c08 Mon Sep 17 00:00:00 2001
From: Ramon Moesching <ramon.moesching@netmodule.com>
Date: Mon, 25 Feb 2019 16:45:17 +0100
Subject: [PATCH] socket-uart: Change to correct systemd type and revise socat
 pty parameters

Systemd service file Type "forking" leads to service restart which
caused socket disconnection. ExecStart process was never forked.
Now Type=simple fixed this issue. It' anyway recommended for
long running tasks.

Socat:
- Fixed typo rawer to raw
- Set echo off
- Defined bitrate

BugzID: 52063

Signed-off-by: Ramon Moesching <ramon.moesching@netmodule.com>
---
 recipes-extended/socket-uart/files/socat-socket-uart   | 2 +-
 recipes-extended/socket-uart/files/socket-uart.service | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-extended/socket-uart/files/socat-socket-uart b/recipes-extended/socket-uart/files/socat-socket-uart
index 451bfdc..a259aca 100644
--- a/recipes-extended/socket-uart/files/socat-socket-uart
+++ b/recipes-extended/socket-uart/files/socat-socket-uart
@@ -1,7 +1,7 @@
 #!/bin/sh -
 if [ -x "$(command -v socat)" ]; then
     echo "start listening socket-uart services with server IP $SOCAT_SOCKET_UART_IP on port $SOCAT_SOCKET_UART_PORT"
-    cmd='socat -s pty,link=/dev/ttyUM0,rawer tcp:$SOCAT_SOCKET_UART_IP:$SOCAT_SOCKET_UART_PORT'
+    cmd='socat -s pty,link=/dev/ttyUM0,raw,echo=0,b115200 tcp:$SOCAT_SOCKET_UART_IP:$SOCAT_SOCKET_UART_PORT'
 
     if [[ -n $SOCAT_SOCKET_UART_MSS ]]; then
         eval $cmd,mss=$SOCAT_SOCKET_UART_MSS
diff --git a/recipes-extended/socket-uart/files/socket-uart.service b/recipes-extended/socket-uart/files/socket-uart.service
index 2da460a..c9bdf37 100644
--- a/recipes-extended/socket-uart/files/socket-uart.service
+++ b/recipes-extended/socket-uart/files/socket-uart.service
@@ -2,7 +2,7 @@
 Description=Bind uart socket with pseudo tty based on socat 
 
 [Service]
-Type=forking
+Type=simple
 ExecStart=/usr/bin/socat-socket-uart
 PIDFile=/var/run/socket-uart.pid