LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

env: Don't show "Failed" error message 

"Failed" error message from env_load() only clutters the log with
unnecessary details, as we already have all needed warnings by that
time. Example:

    Loading Environment from FAT... MMC: no card present
    ** Bad device mmc 0 **
    Failed (-5)

Let's only print it in case when DEBUG is defined to keep log clear.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
This commit is contained in:
Sam Protsenko 2018-07-30 19:19:26 +03:00 committed by Tom Rini
parent 60a4df3262
commit 13bbfb4a39
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
env/env.c vendored
View File

@ -186,14 +186,18 @@ int env_load(void)
continue; continue;
printf("Loading Environment from %s... ", drv->name); printf("Loading Environment from %s... ", drv->name);
/*
* In error case, the error message must be printed during
* drv->load() in some underlying API, and it must be exactly
* one message.
*/
ret = drv->load(); ret = drv->load();
if (ret) if (ret) {
printf("Failed (%d)\n", ret); debug("Failed (%d)\n", ret);
else } else {
printf("OK\n"); printf("OK\n");
if (!ret)
return 0; return 0;
}
} }
/* /*