LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

buildman: Don't default to -e when building current source 

We probably don't need to enable this option by default. It is useful to
display only failure boards (not errors) and it is easy to add -e if it
is required. Also update the docs.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Albert Aribaud <albert.u.boot@aribaud.net>
This commit is contained in:
Simon Glass 2014-10-16 01:05:56 -06:00
parent f66153be19
commit 1d8104fe88
2 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
tools/buildman/README
View File

@ -85,10 +85,10 @@ branch. Put all your commits in a branch, set the branch's upstream to a
valid value, and all will be well. Otherwise buildman will perform random valid value, and all will be well. Otherwise buildman will perform random
actions. Use -n to check what the random actions might be. actions. Use -n to check what the random actions might be.
If you just want to build the current source tree, leave off the -b flag. If you just want to build the current source tree, leave off the -b flag
This will display results and errors as they happen. You can still look and add -e. This will display results and errors as they happen. You can
at them later using -s. Note that buildman will assume that the source still look at them later using -se. Note that buildman will assume that the
has changed, and will build all specified boards in this case. source has changed, and will build all specified boards in this case.
Buildman is optimised for building many commits at once, for many boards. Buildman is optimised for building many commits at once, for many boards.
On multi-core machines, Buildman is fast because it uses most of the On multi-core machines, Buildman is fast because it uses most of the
@ -693,9 +693,9 @@ Quick Sanity Check
================== ==================
If you have made changes and want to do a quick sanity check of the If you have made changes and want to do a quick sanity check of the
currently-checked-out source, run buildman without the -b flag. This will currently checked-out source, run buildman without the -b flag. This will
build the selected boards and display build status and errors as it runs build the selected boards and display build status as it runs (i.e. -v is
(i.e. -v amd -e are enabled automatically). enabled automatically). Use -e to see errors/warnings as well.
Other options Other options
@ -752,7 +752,7 @@ an error and green indicating that a commit fixed an error. Use the -e
flag to see the full errors and -l to see which boards caused which errors. flag to see the full errors and -l to see which boards caused which errors.
If you really want to see build results as they happen, use -v when doing a If you really want to see build results as they happen, use -v when doing a
build (-e will be enabled automatically). build (and -e to see the errors/warnings too).
You don't need to stick around on that branch while buildman is running. It You don't need to stick around on that branch while buildman is running. It
checks out its own copy of the source code, so you can change branches, checks out its own copy of the source code, so you can change branches,
@ -816,11 +816,10 @@ TODO
This has mostly be written in my spare time as a response to my difficulties This has mostly be written in my spare time as a response to my difficulties
in testing large series of patches. Apart from tidying up there is quite a in testing large series of patches. Apart from tidying up there is quite a
bit of scope for improvement. Things like better error diffs, easier access bit of scope for improvement. Things like better error diffs and easier
to log files, error display while building. Also it would be nice it buildman access to log files. Also it would be nice it buildman could 'hunt' for
could 'hunt' for problems, perhaps by building a few boards for each arch, problems, perhaps by building a few boards for each arch, or checking
or checking commits for changed files and building only boards which use commits for changed files and building only boards which use those files.
those files.
Credits Credits

1
tools/buildman/control.py
View File

@ -188,7 +188,6 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
else: else:
series = None series = None
options.verbose = True options.verbose = True
options.show_errors = True
# By default we have one thread per CPU. But if there are not enough jobs # By default we have one thread per CPU. But if there are not enough jobs
# we can have fewer threads and use a high '-j' value for make. # we can have fewer threads and use a high '-j' value for make.