LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sandbox: cros_ec: fix uninitialized use of len 

Building with gcc-5.2 raises this warning:

drivers/misc/cros_ec_sandbox.c: In function cros_ec_sandbox_packet:
drivers/misc/cros_ec_sandbox.c:483:5: warning: len may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (len < 0)
     ^

If the function process_cmd() is called with
req_hdr->command == EC_CMD_ENTERING_MODE, the value of len will be
returned uninitialized.

Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Acked-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Daniel Schwierzeck 2015-11-06 14:15:37 +01:00 committed by Simon Glass
parent b6ff6ce60c
commit 3f51a772d4
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/misc/cros_ec_sandbox.c
View File

@ -460,6 +460,7 @@ static int process_cmd(struct ec_state *ec,
len = cros_ec_keyscan(ec, resp_data); len = cros_ec_keyscan(ec, resp_data);
break; break;
case EC_CMD_ENTERING_MODE: case EC_CMD_ENTERING_MODE:
len = 0;
break; break;
default: default:
printf(" ** Unknown EC command %#02x\n", req_hdr->command); printf(" ** Unknown EC command %#02x\n", req_hdr->command);