LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MA-14293 [coverity] imx8: Fix double free issue 

Fix coverity issue CID 3298992: Double free (USE_AFTER_FREE)
double_free: Calling free frees pointer rsrc_data which has
already been freed.

Check the rsrc_data buffer before free to avoid free NULL
pointer.

Change-Id: I781e87667a5d3bbe25ec12fbae8e3958d9b29244
Signed-off-by: Luo Ji <ji.luo@nxp.com>
This commit is contained in:
Luo Ji 2019-03-07 20:08:50 +08:00
parent ff76415a1b
commit 4b28b03dbb
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
arch/arm/mach-imx/imx8/partition.c
View File

@ -170,6 +170,7 @@ static int do_part_dtb(int argc, char * const argv[])
pad_data = kmalloc(pad_size, __GFP_ZERO); pad_data = kmalloc(pad_size, __GFP_ZERO);
if (!pad_data) { if (!pad_data) {
debug("No mem\n"); debug("No mem\n");
if (rsrc_data != NULL)
free(rsrc_data); free(rsrc_data);
return CMD_RET_FAILURE; return CMD_RET_FAILURE;
} }
@ -235,8 +236,10 @@ static int do_part_dtb(int argc, char * const argv[])
free_data: free_data:
if (pad_size > 0) if (pad_size > 0)
free(pad_data); free(pad_data);
if (rsrc_size > 0) if (rsrc_size > 0) {
free(rsrc_data); free(rsrc_data);
rsrc_data = NULL;
}
} }
} }