LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spl: fit: Skip attempting to load 0 length image 

commit 6d99f86695 upstream.

When, for various reasons, a bad FIT image is used where a loadable
image is marked as 0 length, attempt is made for a 0 length allocation and
read of 0 byte read operation.

Instead provide warning in log and skip attempting to do such a load.

Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Aswath Govindraju <a-govindraju@ti.com>
[praneeth@ti.com: forward port commit '6d99f866952b' from upstream u-boot/next]
Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
This commit is contained in:
Nishanth Menon 2022-01-04 14:35:02 -06:00 committed by Praneeth Bajjuri
parent 816bdfe256
commit 4cfd609f8d
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/spl/spl_fit.c
View File

@ -282,6 +282,13 @@ static int spl_load_fit_image(struct spl_load_info *info, ulong sector,
if (fit_image_get_data_size(fit, node, &len)) if (fit_image_get_data_size(fit, node, &len))
return -ENOENT; return -ENOENT;
/* Dont bother to copy 0 byte data, but warn, though */
if (!len) {
log_warning("%s: Skip load '%s': image size is 0!\n",
__func__, fit_get_name(fit, node, NULL));
return 0;
}
load_ptr = (load_addr + align_len) & ~align_len; load_ptr = (load_addr + align_len) & ~align_len;
length = len; length = len;