hancock: review sja1105

This commit is contained in:
Rene Straub 2018-06-19 08:38:30 +02:00 committed by Patrick Zysset
parent 54d13f60cb
commit 628115260b
1 changed files with 18 additions and 0 deletions

View File

@ -9,10 +9,28 @@
#ifndef _SJA1105_H_ #ifndef _SJA1105_H_
#define _SJA1105_H_ #define _SJA1105_H_
/* TODO: make return type uint32_t */
int sja1105_read_reg(struct spi_slave *spislave, uint32_t adress); int sja1105_read_reg(struct spi_slave *spislave, uint32_t adress);
/* TODO: Remove return value, since ignored anyway */
int sja1105_write_reg(struct spi_slave *spislave, uint32_t address, uint32_t data); int sja1105_write_reg(struct spi_slave *spislave, uint32_t address, uint32_t data);
/* TODO: Find better name -> ... load_firmware / configure / setup ... */
void sja1105_static_init(struct spi_slave *spislave, int config); void sja1105_static_init(struct spi_slave *spislave, int config);
/* TODO: Find better name -> ... configure_mode_and_clocks ... */
void sja1105_dynamic_init(struct spi_slave *spislave); void sja1105_dynamic_init(struct spi_slave *spislave);
/* TODO: Add method to configure IO pads (unused IOs)
* Set pull downs where required.
* Drive strength settings...
*
* void sja1105_configure_io(void)
*/
/* TODO: Add sja1105_init(struct spi_slave *spi)
* Takes and remembers SPI driver for later calls.
* Remove spislave argument from other methods.
*/
#endif #endif