LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "spi: cadence_qspi_apb: Don't use DMA in DTR mode" 

This reverts commit 246ca5eae0.

SPI NOR core has been updated to use DMA safe buffer during
SFDP read thus making the below check to not use DMA unnecessary.
The check also affects the QSPI read performance significantly.

QSPI Read performance with the check:

=> sf probe 1:0
SF: Detected mt25qu512a with page size 256 Bytes, erase size 64 KiB, total 64 MiB
=> time sf read ${loadaddr} 0x0 0x4000000
device 0 whole chip
SF: 67108864 bytes @ 0x0 Read: OK
time: 17.621 seconds

QSPI Read performance without check:

=> sf probe 1:0
SF: Detected mt25qu512a with page size 256 Bytes, erase size 64 KiB, total 64 MiB
=> time sf read ${loadaddr} 0x0 0x4000000
device 0 whole chip
SF: 67108864 bytes @ 0x0 Read: OK
time: 4.032 seconds

Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
This commit is contained in:
Vaishnav Achath 2022-06-08 16:44:46 +05:30 committed by Anand Gadiyar
parent 1f57340c71
commit 7da7c03f59
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/spi/cadence_qspi_apb.c
View File

@ -1005,7 +1005,7 @@ cadence_qspi_apb_direct_read_execute(struct cadence_spi_platdata *plat,
}
if (!cadence_qspi_apb_use_phy(plat, op)) {
if (!op->data.dtr || dma_memcpy(buf, plat->ahbbase + from, len) < 0)
if (dma_memcpy(buf, plat->ahbbase + from, len) < 0)
memcpy_fromio(buf, plat->ahbbase + from, len);
if (!cadence_qspi_wait_idle(plat->regbase))