LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i2c: mxc: Fix dev_err being called on a nonexistant variable 

The udevice we are working with is called `bus` and not `dev`.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Heiko Schocher <hs@denx.de>
Tested-by: Patrick Delaunay <patrick.delaunay@st.com>
This commit is contained in:
Sean Anderson 2020-09-15 10:44:39 -04:00 committed by Tom Rini
parent e579230b37
commit b4f11dfcbd
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/i2c/mxc_i2c.c
View File

@ -941,7 +941,8 @@ static int mxc_i2c_probe(struct udevice *bus)
*/ */
ret = fdt_stringlist_search(fdt, node, "pinctrl-names", "gpio"); ret = fdt_stringlist_search(fdt, node, "pinctrl-names", "gpio");
if (ret < 0) { if (ret < 0) {
debug("i2c bus %d at 0x%2lx, no gpio pinctrl state.\n", bus->seq, i2c_bus->base); debug("i2c bus %d at 0x%2lx, no gpio pinctrl state.\n",
bus->seq, i2c_bus->base);
} else { } else {
ret = gpio_request_by_name_nodev(offset_to_ofnode(node), ret = gpio_request_by_name_nodev(offset_to_ofnode(node),
"scl-gpios", 0, &i2c_bus->scl_gpio, "scl-gpios", 0, &i2c_bus->scl_gpio,
@ -952,7 +953,9 @@ static int mxc_i2c_probe(struct udevice *bus)
if (!dm_gpio_is_valid(&i2c_bus->sda_gpio) || if (!dm_gpio_is_valid(&i2c_bus->sda_gpio) ||
!dm_gpio_is_valid(&i2c_bus->scl_gpio) || !dm_gpio_is_valid(&i2c_bus->scl_gpio) ||
ret || ret2) { ret || ret2) {
dev_err(dev, "i2c bus %d at %lu, fail to request scl/sda gpio\n", bus->seq, i2c_bus->base); dev_err(bus,
"i2c bus %d at %lu, fail to request scl/sda gpio\n",
bus->seq, i2c_bus->base);
return -EINVAL; return -EINVAL;
} }
} }