LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] Avoid assigning PCI resources from zero address 

If a PCI IDE card happens to get a zero address assigned to it, the Linux IDE
core complains and IDE drivers fails to work.  Also, assigning zero to a BAR
was illegal according to PCI 2.1 (the later revisions seem to have excluded the
sentence about "0" being considered an invalid address) -- so, use a reasonable
starting value of 0x1000 (that's what the most Linux archs are using).

Alternatively, one might have fixed the calls to pci_set_region() individually
(some code even seems to have taken care of this issue) but that would have
been a lot more work. :-)

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Acked-by: Stefan Roese <sr@denx.de>
This commit is contained in:
Sergei Shtylyov 2007-04-23 15:30:39 +02:00 committed by Wolfgang Denk
parent 9ffd451afe
commit b7598a43f2
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/pci_auto.c
View File

@ -34,7 +34,12 @@
void pciauto_region_init(struct pci_region* res) void pciauto_region_init(struct pci_region* res)
{ {
res->bus_lower = res->bus_start; /*
* Avoid allocating PCI resources from address 0 -- this is illegal
* according to PCI 2.1 and moreover, this is known to cause Linux IDE
* drivers to fail. Use a reasonable starting value of 0x1000 instead.
*/
res->bus_lower = res->bus_start ? res->bus_start : 0x1000;
} }
void pciauto_region_align(struct pci_region *res, unsigned long size) void pciauto_region_align(struct pci_region *res, unsigned long size)