LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

exynos: spi: Convert the timeout to debug() 

Since the timeout is reported through normal channels, and is sometimes
expected (e.g. if the bus is being probed for a non-existent device),
don't display the message in the driver.

In general, drivers should not write to the console as this limits their
usefulness in error conditions.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2015-07-02 18:16:11 -06:00
parent 048dba0191
commit c7d50e7fb9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/spi/exynos_spi.c
View File

@ -190,9 +190,9 @@ static int spi_rx_tx(struct exynos_spi_priv *priv, int todo,
spi_request_bytes(regs, toread, step); spi_request_bytes(regs, toread, step);
} }
if (priv->skip_preamble && get_timer(start) > 100) { if (priv->skip_preamble && get_timer(start) > 100) {
printf("SPI timeout: in_bytes=%d, out_bytes=%d, ", debug("SPI timeout: in_bytes=%d, out_bytes=%d, ",
in_bytes, out_bytes); in_bytes, out_bytes);
return -1; return -ETIMEDOUT;
} }
} }