LM
/
u-boot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MLK-14862 net: eth-uclass: add return value check 

Add return value check

Coverity 392391

Signed-off-by: Peng Fan <peng.fan@nxp.com>
(cherry picked from commit 3f8052264b97b0bf87452876307ca115b7a518a3)
This commit is contained in:
Peng Fan 2017-05-11 10:21:48 +08:00 committed by Ye Li
parent aed4820fa8
commit edd2be5f4b
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
net/eth-uclass.c
View File

@ -3,6 +3,8 @@
* Wolfgang Denk, DENX Software Engineering, wd@denx.de.
* Joe Hershberger, National Instruments
*
* Copyright 2017 NXP
*
* SPDX-License-Identifier: GPL-2.0+
*/
@ -40,8 +42,12 @@ static int eth_errno;
static struct eth_uclass_priv *eth_get_uclass_priv(void)
{
struct uclass *uc;
int ret;
ret = uclass_get(UCLASS_ETH, &uc);
if (ret)
return NULL;
uclass_get(UCLASS_ETH, &uc);
assert(uc);
return uc->priv;
}
@ -102,6 +108,7 @@ struct udevice *eth_get_dev_by_name(const char *devname)
struct udevice *it;
struct uclass *uc;
int len = strlen("eth");
int ret;
/* Must be longer than 3 to be an alias */
if (!strncmp(devname, "eth", len) && strlen(devname) > len) {
@ -109,7 +116,10 @@ struct udevice *eth_get_dev_by_name(const char *devname)
seq = simple_strtoul(startp, &endp, 10);
}
uclass_get(UCLASS_ETH, &uc);
ret = uclass_get(UCLASS_ETH, &uc);
if (ret)
return NULL;
uclass_foreach_dev(it, uc) {
/*
* We need the seq to be valid, so try to probe it.