From fe324483b48c0e6f70e34055545da408216acefb Mon Sep 17 00:00:00 2001 From: Ye Li Date: Mon, 12 Nov 2018 01:16:37 -0800 Subject: [PATCH] MLK-20240-3 gis: Add NULL pointer check Fix coverity issue CID 3768406: Dereference null return value (NULL_RETURNS) dereference: Dereferencing a pointer that might be NULL gis_input when calling strcmp. The gis_input may returns NULL from env_get, need check it before strcmp. Signed-off-by: Ye Li --- drivers/video/mxc_gis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/mxc_gis.c b/drivers/video/mxc_gis.c index 5ee35ab2a9..a312fe0c8c 100644 --- a/drivers/video/mxc_gis.c +++ b/drivers/video/mxc_gis.c @@ -321,7 +321,7 @@ void mxc_enable_gis(void) gis_running = false; - if (!strcmp(gis_input, "vadc")) { + if (gis_input != NULL && !strcmp(gis_input, "vadc")) { printf("gis input --- vadc\n"); /* vadc_in 0 */ vadc_config(0);