46703cd9f3
The recv variable in sandbox_tpm2_fill_buf() is a pointer on a pointer
of a char array. It means accessing *recv is the char array pointer
itself while **recv is the first character of that array. There is no
need for such indirection here, so simplify the code.
Simplifying things will make the last assignment right: "*recv = NULL"
is now correct. The issue has been found by the following Coverity
Scan report:
CID 183371: Incorrect expression (UNUSED_VALUE)
Assigning value "4UL" to "*recv" here, but that stored value is overwritten before it can be used.
232 *recv += sizeof(rc);
233
234 /* Add trailing \0 */
235 *recv = NULL;
While at simplifying things, use '\0' instead of NULL when adding an
empty char at the end of the buffer.
Reported-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| tpm-uclass.c | ||
| tpm2_tis_sandbox.c | ||
| tpm2_tis_spi.c | ||
| tpm_atmel_twi.c | ||
| tpm_internal.h | ||
| tpm_tis.h | ||
| tpm_tis_infineon.c | ||
| tpm_tis_lpc.c | ||
| tpm_tis_sandbox.c | ||
| tpm_tis_st33zp24_i2c.c | ||
| tpm_tis_st33zp24_spi.c | ||