b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
||
|---|---|---|
| .. | ||
| imx8 | ||
| imx8m | ||
| imxrt | ||
| mx2 | ||
| mx3 | ||
| mx5 | ||
| mx6 | ||
| mx7 | ||
| mx7ulp | ||
| mxs | ||
| Kconfig | ||
| Makefile | ||
| cache.c | ||
| cmd_bmode.c | ||
| cmd_dek.c | ||
| cmd_hdmidet.c | ||
| cmd_nandbcb.c | ||
| cpu.c | ||
| ddrmc-vf610-calibration.c | ||
| ddrmc-vf610-calibration.h | ||
| ddrmc-vf610.c | ||
| hab.c | ||
| i2c-mxv7.c | ||
| imx_bootaux.c | ||
| init.c | ||
| iomux-v3.c | ||
| lowlevel.S | ||
| mac.c | ||
| misc.c | ||
| mkimage_fit_atf.sh | ||
| mmc_env.c | ||
| mmdc_size.c | ||
| rdc-sema.c | ||
| sata.c | ||
| speed.c | ||
| spl.c | ||
| spl_imx_romapi.c | ||
| spl_qspi.cfg | ||
| spl_sd.cfg | ||
| syscounter.c | ||
| timer.c | ||
| video.c | ||