Commit Graph

50111 Commits

Author SHA1 Message Date
Ye Li 3f4b5b9cf4 MLK-20559-9 Android: imx8qm/qxp: Update android configurations
Due to some USB configurations are moved to header file to bypass
SPL build. Changes android and androidatuo defconfigs and header
files to avoid build break.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li 188aea7489 MLK-20559-8 imx8qm/qxp: Update MEK board codes to support UUU
Enable the SPL SDP driver and USB driver in MEK board codes and defconfigs.
Because the USB driver needs larger malloc pool, increase the malloc size
and disable simple malloc

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li 69dfae092f MLK-20559-7 tcpc: Bypass the vbus disable for SPL
The SPL won't use host mode, and the tcpc is default set as device mode.
So we don't need to access tcpc in SPL.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li cddb0fde37 MLK-20559-6 f_sdp: Support searching and loading FIT or container image
Add support to f_sdp to search and load iMX8 container image or iMX8M
FIT image by new UUU command SDPV.

When using the SDPV, the uuu will continue to send out data after first
level boot loader used by ROM. This means uuu won't skip to the offset
of the second boot loader, and the padding data before second boot loader
will be sent out. So we have to search the FIT header or container header
in the buffer that SDP received.

The new BCD value is used by uuu to distinguish if the SPL supports the
SDPV.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li 1f6b3efc62 MLK-20559-5 f_sdp: Add a callback to clean up USB driver
Because SDP directly jumps to next level boot image, we'd better
clean up the USB driver before it. Implement a weak callback function,
that spl sdp can use it to clean up USB driver.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li 6ca3fc0bbd MLK-20559-4 f_sdp: Fix wrong usb request size
Because the buffer length of sdp usb request is 65, we have to allocate
65 bytes not 64 bytes. Otherwise there is potential buffer overflow.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li 825c6f13b7 MLK-20559-3 f_sdp: Add high speed endpoint descriptor
Add HS endpoint descriptor for SDP. So that we can use high speed endpoint,
and the SDP device can send packet with 512 byte size.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li 18cbba9e33 MLK-20559-2 spl: Enable cdns3 USB driver for SPL building
The imx8qm/qxp uses cdns3 USB driver. To support SPL SDP, we have
to enable the driver.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li dba0d7c7dc MLK-20559-1 spl_sdp: Add CONFIG_SPL_SDP_USB_DEV for USB device
Add a new configuration CONFIG_SPL_SDP_USB_DEV to specify the
usb index for spl sdp driver, so that we change use different device.
The default value is 0.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:46:31 -08:00
Ye Li bb5ed5774d MLK-20666-2 DTS: imx8mq: Enable i2c force idle
Add i2c gpio pinctrl settings and properties to enable i2c force idle.

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
2019-01-08 21:45:35 -08:00
Ye Li 94b6e0f525 MLK-20666-1 DTS: imx8mm: Enable i2c force idle
Add i2c gpio pinctrl settings and properties to enable i2c force idle.
Avoid any i2c bus not released by device during reboot.

Signed-off-by: Ye Li <ye.li@nxp.com>
2019-01-08 21:45:18 -08:00
Ji Luo 0e202ab93e MA-13906 [Trusty] Support commands to set attestation materials
Keystore attestation requires provision keys and cerificate chains into
secure storage. Add commands to support rsa/ecdsa keys and certificate
chains provision, each key/certificate should be staged before provision.
Usage:
  Set rsa attestation key:
      fastboot stage <path-to-rsa-atte-key>
      fastboot oem set-rsa-atte-key
  Set ec attestation key:
      fastboot stage <path-to-ec-atte-key>
      fastboot oem set-ec-atte-key
  Append rsa attestation certs:
      fastboot stage <path-to-rsa-atte-cert>
      fastboot oem append-rsa-atte-cert
  Append ec attestation certs:
      fastboot stage <path-to-ec-atte-cert>
      fastboot oem append-ec-atte-cert

Test: Pass CTS cases:
      android.keystore.cts.KeyAttestationTest#testRsaAttestation
      android.keystore.cts.KeyAttestationTest#testEcAttestation

Change-Id: Ic3ed87e7e328a39b0f1bfb163356ea9e37d2f4fc
Signed-off-by: Ji Luo <ji.luo@nxp.com>
2019-01-08 17:18:10 +08:00
Ji Luo e29e4022c5 MA-13904 [Trusty] Pass root trust to keymaster service
Pass the verified boot key hash to keymaster, it will be
treated as the root trust in keymaster service.
Also set the 'initialized' flag after initializing the
keymaster client or set keymaster boot parameters will fail.

Test: Pass CTS cases:
      android.keystore.cts.KeyAttestationTest#testRsaAttestation
      android.keystore.cts.KeyAttestationTest#testEcAttestation

Change-Id: I486b5493826160f42c61a3da0e6cd769df92254d
Signed-off-by: Ji Luo <ji.luo@nxp.com>
2019-01-08 16:04:05 +08:00
Ye Li 4bddbabb10 MLK-19973 mx6ulz: Change to load uTee-6ulzevk for 6ULZ
When running on iMX6ULZ, need to set tee_file to uTee-6ulzevk not
uTee-6ullevk. Thus, add findtee script into env to set correct tee
file before booting.

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
2019-01-07 21:52:51 -08:00
yang.tian 3957eaafc0 MA-13879-2 Revert adding bootargs for multi-vendor of 8mm
Remove this patch to specify wifi vendor info from uboot,
instead we directly add the bootargs in cmdline.

Revert commit 9f1a11bdc3
MA-13879[wifi concurrency] Add bootargs to set a
property for wifi vendor of 8mm

Change-Id: Icf7e89df2b4993f6e17a6b7cf38b891591f680d7
Signed-off-by: yang.tian <yang.tian@nxp.com>
2019-01-07 16:22:53 +08:00
Ye Li 9e0a33cacc MLK-20668-2 fat: Fix issue in rootdir table flush for FAT16/12
The FAT16/12 has rootdir area before data area, and the clusters for
rootdir are not mantained by FAT table. So we don't need to find empty
cluster for next rootdir space, just use next dir cluster. And the FAT
table don't need to update for this new dir cluster.

Signed-off-by: Ye Li <ye.li@nxp.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
2019-01-03 19:31:05 -08:00
Seung-Woo Kim 615283d0eb MLK-20668-1 fs: fat: fix wrong casting to unsigned value of sect_to_cluster()
After the commit 265edc03d5 ("fs/fat: Clean up open-coded sector
<-> cluster conversions"), it is hung up writing new file to FAT16
disk with more than 19 files in armv7. It is because result value
of sect_to_cluster() is not proper by casting from signed value to
unsigned value. Fix the wrong casting of sect_to_cluster().

Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
(cherry picked from commit 6e2151c729)
2019-01-03 19:30:52 -08:00
Ye Li 81385a5b07 MLK-20669 lpuart: Fix tstc issue in Non-DM driver
The tstc function in Non-DM driver does not check the LPUART_FLAG_REGMAP_32BIT_REG
flag, it always use 8 bits register version and cause issue in 8QM/QXP SPL.

Signed-off-by: Ye Li <ye.li@nxp.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
2019-01-03 01:21:20 -08:00
yang.tian 9f1a11bdc3 MA-13879[wifi concurrency] Add bootargs to set a property for wifi vendor of 8mm
Since evk_8mm will support both QCA9377 and BCM43455 wifi,
add bootargs to pass a property to differ which wifi is used.

Change-Id: I83f7fd657dbdedc54931148cd6dd3d59563b6ec3
Signed-off-by: yang.tian <yang.tian@nxp.com>
2019-01-03 10:33:00 +08:00
Ye Li cedcc6634b MLK-20663 imx8: Fix malloc issue in container parser
The size used for malloc is wrong, the following read function will
read 1KB to the container header buffer not the size of the header.

Signed-off-by: Ye Li <ye.li@nxp.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
2018-12-28 18:04:42 -08:00
Ye Li b9c0bf271d MLK-20660 imx8: Check the ROM pass over info only for RevA
Only the ROM on RevA will pass over some info into OCRAM. U-boot gets
the info to determine whether it is eMMC fastboot.
Thus, change that codes only for RevA, otherwise if we protect
the OCRAM used by SPL on RevB, u-boot will fail to access it.

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
2018-12-26 20:51:46 -08:00
Ye Li 145c359ca5 MLK-20655-2 imx8qm/qxp: Fix wrong gpio resource used in SPL
Since the gpio non-dm driver maps to wrong GPIO register, the SPL
also powers up wrong GPIO resources.

Signed-off-by: Ye Li <ye.li@nxp.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
2018-12-26 01:25:41 -08:00
Ye Li 81154aed77 MLK-20655-1 mxc_gpio: Fix non-DM driver issue for iMX8 platforms
The port index is not calculated correctly. It should not be descreased,
because the gpio number is from 0 on imx8 platform.
Otherwise we will access wrong registers.

Signed-off-by: Ye Li <ye.li@nxp.com>
2018-12-26 01:25:41 -08:00
Ye Li 9e406ea46a MLK-20654 imx8: Recover SPL data section for partition reboot
When doing partition reboot, the boot image won't be reloaded by ROM,
it is just CPU reset to boot entry. The SW has to keep the boot image
inside the RAM unchanged. It includes both the TEXT section and DATA
section.

For SPL, the problem is DATA section will be updated at runtime, so in
next partition reboot the data is not same as the initial value from
cold boot. If any code depends on the initial value, then it will have
problem.

This patch introduces a mechanism to recover the data section for partition
reboot. It adds a new section in image for saving data section. When from cold
boot, the data section will be saved to that new section at SPL early phase.
When from partition reboot, the data section will be restored from the new section.

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
2018-12-26 01:25:41 -08:00
faqiang.zhu 45e94c08e6 MA-13850-1 change the device tree and DDR related configuration
After two defconfig files are directly copied from 8mm_evk_android
for 8mm_evk_ddr4_android, this patch adapt the defconfig files.

Device tree used in defconfig files are modifed, a configuration
item of "CONFIG_TARGET_IMX8MM_EVK" is modified to be
"CONFIG_TARGET_IMX8MM_DDR4_EVK"

Change-Id: Ib48449d0c7abab45aff3a58a9c78c481290e7e6a
Signed-off-by: faqiang.zhu <faqiang.zhu@nxp.com>
2018-12-26 10:31:10 +08:00
faqiang.zhu 4e36b29d2c MA-13850 add two defconfig files for evk_imx8mm ddr4 version
Add two defconfig files for imx8mm ddr4 version.
These two defconfig files are:
imx8mm_ddr4_evk_android_defconfig
imx8mm_ddr4_evk_android_uuu_defconfig

They are respectively copy from the files below:
imx8mm_evk_android_defconfig
imx8mm_evk_android_uuu_defconfig

Change-Id: Ic2ab2b51328b23446e8f264eb27308d226b57295
Signed-off-by: faqiang.zhu <faqiang.zhu@nxp.com>
2018-12-26 10:29:48 +08:00
Ji Luo e05d44f550 MA-13832 [Trusty] Support random rpmb key set
Sometimes we need to set random rpmb key which is invisible
except for the device.
Generate the random key with hwcrypto interface and support
fastboot command "fastboot oem set-rpmb-random-key" to set it.

Test: build and boot on imx8q.

Change-Id: I44e1b6b091366d8ffceb1159fc65c17610ce5243
Signed-off-by: Ji Luo <ji.luo@nxp.com>
2018-12-24 09:13:38 +08:00
Ji Luo 4668e8a45e MA-13831-3 [trusty] Add command to generate rng with CAAM
Add new hwcrypto command to support rng generation with CAAM.

Test: rng generated on imx8qxp_mek.

Change-Id: I756f3e99423f0f9dfc2bcd30117a3f96e9f5f2f7
Signed-off-by: Ji Luo <ji.luo@nxp.com>
2018-12-24 09:13:37 +08:00
faqiang.zhu 78becc7f83 MA-13303 fix the issue with 8qm boot from eMMC to flash SD
For mek_8qm, bootloader offset in SD card is 32kb, in eMMC
bootpartition, it's 0kb. This patch fix the issue that bootloader offset
used in uboot is always based on the device that the board boot from.

Now, if uboot environment variable "target_ubootdev" is set, bootloader
offset used in uboot is based on the device "target_ubootdev" specified.
So boot from eMMC to flash SD, the board can boot from SD and vice versa.

Change-Id: Ia2cd64ba6ece02b98ea3d2addbce00b1661077de
Signed-off-by: faqiang.zhu <faqiang.zhu@nxp.com>
2018-12-21 20:12:49 +08:00
Ye Li ab6b18bcf3 MLK-20635 imx8: clock: Fix GPR settings for FEC
FEC has some clock settings inside DSC GPR. Kernel configures them,
but u-boot not. So when doing partition reset, the GPR keeps the value
from kernel, and cause clock issue to u-boot FEC: kernel enables the
divclk in GPR and set the clock slice to 250Mhz, u-boot configures the
clock slice to 125Mhz, the divclk causes the RGMII TX CLK to 62.5Mhz.

Fix the issue by aligning the GPR and clock slice settings with kernel

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Fugang Duan <fugang.duan@nxp.com>
2018-12-20 23:52:32 -08:00
faqiang.zhu 9da9e76a44 MA-13785 remove the fastboot command of ucmd and acmd
To avoid end user executing uboot command through fastboot, the fastboot
command of "ucmd" and "acmd" in the uboot to be flashed into
non-volatile storage device is removed in this partch.

Change-Id: I999b8688a53c2201d02979be68266afc110dfb15
Signed-off-by: faqiang.zhu <faqiang.zhu@nxp.com>
2018-12-20 12:30:29 +08:00
Breno Lima 2ee4bd1214 MLK-20583-2 imx: mx6sabreauto: Enable OCOTP CTRL clock in DCD and plugin
The HAB code can not set Field Return and SRK Revoke sticky bits in case
OCOTP CTRL clock is gated out.

In case we disable OCOTP CTRL clock in DCD and plugin those features may
not operate as expected.

Keep OCOTP CTRL clock enabled in DCD and plugin so HAB can propely lock
those features, users should use the CSF Unlock command to prevent those
features from being locked.

Signed-off-by: Breno Lima <breno.lima@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>
2018-12-19 17:46:15 -08:00
Breno Lima fe78359704 MLK-20583-1 imx: mx6sabresd: Enable OCOTP CTRL clock in DCD and plugin
The HAB code can not set Field Return and SRK Revoke sticky bits in case
OCOTP CTRL clock is gated out.

In case we disable OCOTP CTRL clock in DCD and plugin those features may
not operate as expected.

Keep OCOTP CTRL clock enabled in DCD and plugin so HAB can propely lock
those features, users should use the CSF Unlock command to prevent those
features from being locked.

Signed-off-by: Breno Lima <breno.lima@nxp.com>
2018-12-19 17:45:29 -08:00
Bai Ping f4c76d52da MLK-20602 imx8mq: Change clock source of GIC
Change the the GIC clock source to sys_pll2_200m.
Improve the IRQ response latency.

Signed-off-by: Bai Ping <ping.bai@nxp.com>
2018-12-19 14:51:13 +08:00
faqiang.zhu d152aa00a6 MA-13788 add defconfig for aiy_imx8mq uboot used by uuu
To align aiy_imx8mq uboot used by uuu with other platforms, a defconfig
used to configure and build uboot used by uuu is added.

This "imx8mq_aiy_android_uuu_defconfig" for now is a copy of below file:
imx8mq_aiy_android_defconfig

Change-Id: I7c96297fa13fa7bb02117ceee8675e95f86e7b60
Signed-off-by: faqiang.zhu <faqiang.zhu@nxp.com>
2018-12-19 09:12:08 +08:00
faqiang.zhu e2ae3209e2 MA-13787 disable FS_FAT write feature for Android Auto uboot
Since FS_FAT has been removed from uboot for Android Auto to minimize
image size, disable FS_FAT write feature for Android Auto uboot.

Change-Id: I8740735b68759bfd62d53cf7f08287a098b481c4
Signed-off-by: faqiang.zhu <faqiang.zhu@nxp.com>
2018-12-18 21:01:32 +08:00
Li Jun 7d7097a07f MLK-20493-10 usb: gaget: ci: set ep's desc when enable ep
As we need standard usb_ep's desc, so set it when enable ep.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 16:01:08 +08:00
Li Jun 0d7928ce97 MLK-20493-9 usb: gadget: fastboot: use correct max packet size
Change to use wMaxPacketSize of current speed EP desc for request
length wrap up.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Li Jun d2eda0a183 MLK-20493-8 usb: udc: ci: update speed handling
Remove the gadget driver speed check, and set its max_speed to
be USB_SPEED_HIGH.

Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Li Jun 86247b0c88 MLK-20493-7 usb: composite: force gadget to be USB2 for HS only function
If one of functions is not super speed capable, we need force the udc
to be high speed, this is an equivalent implementation of
usb_gadget_udc_set_speed() in kernel but simple, which set the gadget
max_speed to be high speed, so afterwards when start gadget duc can
set the HW to be USB 2.0 mode.

Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Li Jun 1ea5ab027e MLK-20493-6 imx8mq_evk/arm2: Set usb to be super speed
Keep high speed for SPL, but for normal uboot, enable super speed.

Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Li Jun a9dac41fea MLK-20493-5 usb: dwc3: change the dwc3 to be USB3 capable
Change the dwc3 device mode to be super speed capable.

Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Li Jun fd1146e796 MLK-20493-4 usb: cdns3: change device mode to be USB3 by default
Remove high speed force and set it to super speed by default.

Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Li Jun dfe8582b06 MLK-20493-3 usb: gadget: dnl: set dnl to be super speed
Set its max_speed to be super speed.

Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Li Jun a7b7085dec MLK-20493-2 usb: fastboot: add super speed support
Add super speed EP config.

Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Li Jun b0bc5f6d12 MLK-20493-1 usb: gadget: add super speed support
This patch is to add usb gadget super speed support in common
driver, including BOS descriptor and select the super speed
descriptor from function driver.

Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Tested-by: faqiang.zhu <faqiang.zhu@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
2018-12-18 14:38:49 +08:00
Frank Li fcd4ce89df MLK-20594-2 enable fat write for all configuration
Signed-off-by: Frank Li <Frank.Li@nxp.com>
2018-12-14 13:36:14 -06:00
Frank Li 6392ca2f34 MLK-20594-1 fix fat write create file failure when fat12/16
Error: Invalid FAT entry: 0x3ffffffa
create file

when Long file name cross root dir cluster boundry, this issue
happen.

get_long_file_name have not consider fat12/16 case, which rootdir
locate before data area. and try to get next clust directly. Only
FAT32's root dir is located in data area

Signed-off-by: Frank Li <Frank.Li@nxp.com>
2018-12-14 13:36:14 -06:00
Breno Lima 4568f4a4c8 MLK-20553-4 doc: imx: hab: Remove extra hab directory for a cleaner documentation structure
There is no need to have an extra hab directory under doc/imx/:

- doc/imx/hab/ahab/
- doc/imx/hab/habv4/

Remove extra hab directory for a cleaner documentation structure.

Signed-off-by: Breno Lima <breno.lima@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>
2018-12-13 17:46:12 -08:00
Breno Lima 04505024d3 MLK-20553-3 doc: imx: ahab: Add Secure Boot documentation for i.MX8 and i.MX8x SPL targets
The current U-Boot implementation includes SPL targets for i.MX8QM and
i.MXQXP MEK boards:

- imx8qxp_mek_spl_defconfig
- imx8qxp_mek_spl_fspi_defconfig
- imx8qm_mek_spl_defconfig
- imx8qm_mek_spl_fspi_defconfig

The U-Boot proper and ATF are included in an additional container being
necessary a different procedure for signing the flash.bin image.

Add a step-by-step guide covering the signing procedure.
Add a CSF example for the 3rd container.

Signed-off-by: Breno Lima <breno.lima@nxp.com>
Reviewed-by: Frank Zhang <frank.zhang@nxp.com>
Reviewed-by: Marius Grigoras <marius.grigoras@nxp.com>
Reviewed-by: Utkarsh Gupta <utkarsh.gupta@nxp.com>
2018-12-13 17:45:14 -08:00